@Rotonen I'm uncertain how to handle dockerhub building using http://github.com/snowblossomcoin/snowblossom-docker
try to draw your current thinking so i’ll have an easier time figuring out what you’re thinking of
@Clueless it might be a nonsensical point because of our probably very small number of docker users, but my view is that we should have a docker target for each binary
like snowblossom/node:dev for a node, and snowblossom/shackleton:dev to an explorer
but I don't understand docker compose
or how people will want to use it
to me, it makes sense for people to be able to docker run something and from that get an operational thing that they are looking for
docker-compose is like a pile of sysv daemons
but you can reuse the image in a docker compose, just provide the yaml and change the entrypoints in those
@Fireduck I'm basically currently wrapping Everything_deploy.jar and using an entrypoint script to call an entrypoint with a config file or environmental variables. Entrypoint: https://github.com/snowblossomcoin/snowblossom-docker/blob/master/scripts/run/scripts/entrypoint Entrypoints: https://github.com/snowblossomcoin/snowblossom-docker/blob/master/scripts/run/scripts/entrypoints/ Basically, the dockerfile specifies a default command, in this case "node", so the user just does this `docker run -it snowblossom/snowblossom` `docker run -it snowblossom/snowblossom node` `docker run -it snowblossom/snowblossom client`
```#docker-compose.yaml services: node: image: snowblossom/snowblossom # cmd: node (default) explorer: image: snowblossom/snowblossom cmd: explorer environment: SNOWBLOSSOM_EXPLORER_NODE_URI: ``` In this example, docker-compose is running the single snowblossom/snowblossom image, multiple times, but changes the cmd
the upside of this approach is the simplicity of building it
the downside is the image size, but the bulk of each deploy jar is the shared bit anyway
btw. good call on using the upstream jre11 image for the runtime
you can define dependencies across the services too
but i guess this is a minimal example
While we may only have a few users, I think having this ready to go would make approaching much easier for everyone. @Fireduck I'm not against having discrete docker images if you want. I'm just not sure what it does for us or if that's what we want?
I don't feel strongly about anything docker related - please don't take any of my comments are a requirement
I really don't know.
My thinking is a mining pool is more complicated, no need to worry about that from docker
same with mining itself
a pool should be fine and easy to set up from that
but someone might want a node or node+explorer, I'd like to enable to cases easily
and mining is indeed not helped by docker, quite the contrary
if you want to drive adoption, a nice to use thin gui wallet is what people actually want
@Fireduck ^ in the above example, that's precisely what I'm doing. node+explorer :D