2020-11-02 01:39:45
@Rotonen I'm uncertain how to handle dockerhub building using http://github.com/snowblossomcoin/snowblossom-docker
Clueless
2020-11-02 06:58:51
try to draw your current thinking so i’ll have an easier time figuring out what you’re thinking of
Rotonen
2020-11-02 23:23:02
@Clueless it might be a nonsensical point because of our probably very small number of docker users, but my view is that we should have a docker target for each binary
Fireduck
2020-11-02 23:23:21
like snowblossom/node:dev for a node, and snowblossom/shackleton:dev to an explorer
Fireduck
2020-11-02 23:23:33
but I don't understand docker compose
Fireduck
2020-11-02 23:23:46
or how people will want to use it
Fireduck
2020-11-02 23:24:07
to me, it makes sense for people to be able to docker run something and from that get an operational thing that they are looking for
Fireduck
2020-11-02 23:33:04
docker-compose is like a pile of sysv daemons
Rotonen
2020-11-02 23:33:41
but you can reuse the image in a docker compose, just provide the yaml and change the entrypoints in those
Rotonen
2020-11-02 23:34:53
@Fireduck I'm basically currently wrapping Everything_deploy.jar and using an entrypoint script to call an entrypoint with a config file or environmental variables.
Entrypoint: https://github.com/snowblossomcoin/snowblossom-docker/blob/master/scripts/run/scripts/entrypoint
Entrypoints: https://github.com/snowblossomcoin/snowblossom-docker/blob/master/scripts/run/scripts/entrypoints/
Basically, the dockerfile specifies a default command, in this case "node", so the user just does this
`docker run -it snowblossom/snowblossom`
`docker run -it snowblossom/snowblossom node`
`docker run -it snowblossom/snowblossom client`
Clueless
2020-11-02 23:35:53
```#docker-compose.yaml
services:
node:
image: snowblossom/snowblossom
# cmd: node (default)
explorer:
image: snowblossom/snowblossom
cmd: explorer
environment:
SNOWBLOSSOM_EXPLORER_NODE_URI: Clueless
2020-11-02 23:36:37
the upside of this approach is the simplicity of building it
Rotonen
2020-11-02 23:36:58
the downside is the image size, but the bulk of each deploy jar is the shared bit anyway
Rotonen
2020-11-02 23:37:28
btw. good call on using the upstream jre11 image for the runtime
Rotonen
2020-11-02 23:39:09
you can define dependencies across the services too
Rotonen
2020-11-02 23:39:20
but i guess this is a minimal example
Rotonen
2020-11-02 23:41:00
While we may only have a few users, I think having this ready to go would make approaching much easier for everyone.
@Fireduck I'm not against having discrete docker images if you want. I'm just not sure what it does for us or if that's what we want?
Clueless
2020-11-02 23:42:09
I don't feel strongly about anything docker related - please don't take any of my comments are a requirement
Fireduck
2020-11-02 23:42:16
I really don't know.
Fireduck
2020-11-02 23:42:42
My thinking is a mining pool is more complicated, no need to worry about that from docker
Fireduck
2020-11-02 23:42:51
same with mining itself
Fireduck
2020-11-02 23:43:07
a pool should be fine and easy to set up from that
Rotonen
2020-11-02 23:43:10
but someone might want a node or node+explorer, I'd like to enable to cases easily
Fireduck
2020-11-02 23:43:21
and mining is indeed not helped by docker, quite the contrary
Rotonen
2020-11-02 23:43:52
if you want to drive adoption, a nice to use thin gui wallet is what people actually want
Rotonen
2020-11-02 23:44:49
@Fireduck ^ in the above example, that's precisely what I'm doing. node+explorer :D
Clueless