archive snowblossom slack dev
prev 2020-11-29 next
2020-11-29 17:46:02
Fireduck
It should build using the dockerfile in the 'cli' directory
2020-11-29 17:46:08
Fireduck
not hugely important
2020-11-29 17:51:39
Clueless
checking
2020-11-29 17:56:37
Clueless
at a glance it looks fine, dockerhub just flashes when I press "trigger" and nothing happens.
2020-11-29 18:00:07
Clueless
I'd declare this an issue with dockerhub
2020-11-29 18:00:49
Fireduck
yeah, probably something about being in the subdir to do the build
2020-11-29 18:00:51
Fireduck
but I don't know
2020-11-29 18:01:05
Fireduck
it isn't worth a lot of investigation, I can easily just push a new version as needed
2020-11-29 18:01:14
Fireduck
and really no one is likely to run it from docker other than me
2020-11-29 18:02:31
Fireduck
I'll want automatic builds on the other (rosetta) but we will need to split out the docker files. The rosetta spec calls for doing it in a somewhat odd way, they want the dockerfile to pull the git source rather than just using what is in the current repo.
2020-11-29 18:06:05
Fireduck
So we can make one that does exactly what they are asking for
2020-11-29 18:06:21
Fireduck
and one that uses current repo and have that set to build on push
2020-11-29 18:24:04
Rotonen
only on main branch?
2020-11-29 18:24:43
Fireduck
Yeah
2020-11-29 20:24:37
Clueless
@Fireduck subdirectories are pretty normal, I believe dockerhub is just bugging out.
2020-11-29 20:26:57
Clueless
alright, I looked again, javascript console reports `errorMessage: "Branch 'master' not found"`
2020-11-29 20:27:16
Fireduck
oh, it is main or something
2020-11-29 20:27:24
Clueless
and, apparently it's been named "main"
2020-11-29 20:27:25
Fireduck
because master is racist
2020-11-29 20:27:58
Clueless
I vote for keeping with convention in this case. :P
2020-11-29 20:28:03
Fireduck
I'll go rename anything that says "slave" to "comerade-worker"
2020-11-29 20:28:26
Fireduck
the convention has changed. :wink:
2020-11-29 20:28:32
Clueless
wait really
2020-11-29 20:28:40
Fireduck
yeah, github new default is main
2020-11-29 20:32:46
Clueless
Alright, so I renamed the output docker tag to "dev", because "latest" would interfere with pointing to latest tags being built. So, the latest commit would be "dev", and latest release would be "1.2.3" sound reasonable?
2020-11-29 20:34:00
Clueless
and if there are multiple types, perhaps /cli/ should be cli-dev and cli-1.2.3 ?
2020-11-29 20:34:31
Clueless
triggers build
2020-11-29 20:34:58
Fireduck
so the cli will be in snowblossom/rosetta-cli
2020-11-29 20:35:07
Fireduck
the other docker image goes in snowlbossom/rosetta
2020-11-29 20:36:01
Clueless
if that's the convention they/you want, sure.
2020-11-29 20:37:51
Clueless
if cli is just a specific sub component of the repo, I personally generally prefer: `snowblossom/rosetta:cli-1.2.3` I think. but I'm a newb.
2020-11-29 20:38:37
Clueless
heh, renaming that to your convention.
2020-11-29 20:39:15
Fireduck
yeah, they are completely different things that do different things
2020-11-29 20:39:28
Fireduck
the tag name (after the colon) is for different versions of the same concept
2020-11-29 20:39:37
Fireduck
at least that is how I see people using it
2020-11-29 20:40:26
Clueless
I know this is just bikeshedding, but I view the repo as just being "the software" and the tag being a version or specific offshoot of it.
2020-11-29 20:40:56
Fireduck
I see what you are saying
2020-11-29 20:41:07
Fireduck
but the docker user doesn't care where it comes from
2020-11-29 20:41:19
Fireduck
so in my mind it is org/function:version
2020-11-29 20:41:30
Fireduck
version being latest or stable or version numbers
2020-11-29 20:42:13
Clueless
@Fireduck well, do you want a specific output? My default is: rosetta-cli:dev for latest commit and rosetta-cli:1.2.3 for tags? or do you want to configure it?
2020-11-29 20:42:31
Fireduck
that sounds perfect
2020-11-29 20:50:03
Clueless
Also, I personally try to make sure latest typically points to latest release, for user friendliness. Typically I don't expect :dev to always be working. I need to read up on how `latest` tag is used though. I think it automatically points to the last pushed tag?
2020-11-29 20:52:09
Clueless
dunno what triggered that one, but okay. :shrug:
2020-11-29 21:01:34
Fireduck
Ha