2019-10-03 04:40:16
*https://github.com/snowblossomcoin/snowblossom/compare/a0eb84697a62...d26704ab933d*
https://github.com/snowblossomcoin/snowblossom/commit/d26704ab933d97eb08d96a8ec632ac3939086e65 - String normalization
GitHub
2019-10-03 06:01:27
*https://github.com/snowblossomcoin/snowblossom/compare/d26704ab933d...b030174b3bf2*
https://github.com/snowblossomcoin/snowblossom/commit/964315e76dc623fa72f6da7f5a33a06bba65d10d - Setting username
https://github.com/snowblossomcoin/snowblossom/commit/b030174b3bf20d1b895f8342816236637b33656e - Allow fbo to be any address type
GitHub
2019-10-03 16:18:04
@Rotonen please take a look at those changes, especially the unit tests: https://github.com/snowblossomcoin/snowblossom/blob/master/node/test/ForBenefitOfUtilTest.java ```
package node.test;
import snowblossom.node.ForBenefitOfUtil;
import org.junit.Assert;
import org.junit.Test;
public class ForBenefitOfUtilTest
{
@Test
public void testBasic()
{
Assert.assertEquals(ForBenefitOfUtil.normalize("Fräd"), ForBenefitOfUtil.normalize("frad"));
Assert.assertEquals(ForBenefitOfUtil.normalize("FRAD"), ForBenefitOfUtil.normalize("frad"));
Assert.assertEquals("some ape", ForBenefitOfUtil.normalize("🦧"), ForBenefitOfUtil.normalize("🦧"));
Assert.assertEquals("fireduck", ForBenefitOfUtil.normalize("fireduck"), ForBenefitOfUtil.normalize("𝓕ire𝐃uc𝐤"));
Assert.assertEquals("fireduck1", ForBenefitOfUtil.normalize("fireduck1"), ForBenefitOfUtil.normalize("fireduck𝟏"));
Assert.assertNotEquals("different hearts", ForBenefitOfUtil.normalize("♥"), ForBenefitOfUtil.normalize("💚"));
Assert.assertNotEquals("Brown v. Board of Education", ForBenefitOfUtil.normalize("🧑🏾"),ForBenefitOfUtil.normalize("🧑"));
Assert.assertNotEquals("fireduck_", ForBenefitOfUtil.normalize("fireduck-"), ForBenefitOfUtil.normalize("fireduck_"));
Assert.assertNotEquals("fire.duck", ForBenefitOfUtil.normalize("fireduck"), ForBenefitOfUtil.normalize("fire.duck"));
Assert.assertNotEquals("fire♥duck", ForBenefitOfUtil.normalize("fireduck"), ForBenefitOfUtil.normalize("fire♥duck"));
Assert.assertNotEquals("fireduck1", ForBenefitOfUtil.normalize("fireduck1"), ForBenefitOfUtil.normalize("fireduck➊"));
Assert.assertNotEquals("火鸭", ForBenefitOfUtil.normalize("火鸭"), ForBenefitOfUtil.normalize("鸭火"));
Assert.assertNotEquals("simplified vs traditional", ForBenefitOfUtil.normalize("火鸭"), ForBenefitOfUtil.normalize("火鴨"));
}
}
```
Fireduck
2019-10-03 20:39:27
not before sometime next week, fully booked until at least tuesday
Rotonen
2019-10-03 20:45:42
cool
Fireduck
2019-10-03 21:51:58
preliminarily i still don't get why you need to break this one, if you support all of that other stuff below - most european languages will be impacted by that
https://github.com/snowblossomcoin/snowblossom/blob/b030174b3bf20d1b895f8342816236637b33656e/node/test/ForBenefitOfUtilTest.java#L12 ```
Assert.assertEquals(ForBenefitOfUtil.normalize("Fräd"), ForBenefitOfUtil.normalize("frad"));
```
Rotonen
2019-10-03 21:58:26
I don't think it will break anyone, people can register and use whatever markings they want, they just end up reserving the letter collection that it collapses to. So in that case a user could take Fräd (and it would show up in chat/comments like that). It would just prevent someone later from registering frad.
Fireduck
2019-10-03 21:59:18
The collapsed form is never shown to anyone or used by anything other than this index map.
Fireduck
2019-10-03 22:02:49
that'll still annoy people a lot where those things collide across languages
Rotonen
2019-10-03 22:05:45
yeah...that may be
Fireduck