2019-01-29 06:12:39
*https://github.com/snowblossomcoin/snowblossom/compare/d98800accbb5...8c8bd7385501*
https://github.com/snowblossomcoin/snowblossom/commit/8c8bd7385501377f03dfc7c6cc163bd9ac83df83 - word
GitHub
2019-01-29 07:17:56
*https://github.com/snowblossomcoin/snowblossom/compare/8c8bd7385501...f92a76812bea*
https://github.com/snowblossomcoin/snowblossom/commit/f92a76812bea6e3e29255ee3415a366604c4c513 - Remove extra alloc
GitHub
2019-01-29 08:44:55
pff, you broke my build script by putting something which it parses down to `:ShowAlgo_deploy.jar` into the bazel file
Rotonen
2019-01-29 08:45:51
also surfminer is a no go as per `Unrecognized VM option 'CompactStrings'`
Rotonen
2019-01-29 08:50:19
not gonna bother with figuring out how to .bazelrc java8 in there (which i also do have, but as java 11 performs better, meh)
Rotonen
2019-01-29 08:53:57
i am really not a fan of some of the defaults in bazel `character-encoding: file.encoding = ISO-8859-1, defaultCharset = ISO-8859-1`
Rotonen
2019-01-29 08:55:55
ok so it defaults to java8 after all somehow `java-home: /Library/Java/JavaVirtualMachines/jdk1.8.0_192.jdk/Contents/Home/jre`
Rotonen
2019-01-29 08:58:18
my default java home is
```
$ /usr/libexec/java_home -V
Matching Java Virtual Machines (2):
11.0.1, x86_64: "OpenJDK 11.0.1" /Library/Java/JavaVirtualMachines/openjdk-11.0.1.jdk/Contents/Home
1.8.0_192, x86_64: "Java SE 8" /Library/Java/JavaVirtualMachines/jdk1.8.0_192.jdk/Contents/Home
/Library/Java/JavaVirtualMachines/openjdk-11.0.1.jdk/Contents/Home
```
leaving me a bit confused, as bazel claims it explicitly defaults to not java 8, since summer
Rotonen
2019-01-29 09:00:21
oh, https://github.com/bazelbuild/bazel/issues/6245.
Bazel should support it, including:
☐ JDK 11 host runtime support (`--host_javabase`) [https://github.com/bazelbuild/bazel/issues/7219]
☑︎ JDK 11 target runtime support (`--javabase`) *[done]*
☐ support for the Java 11 language level (`--java_toolchain`/`--host_java_toolchain`)
Rotonen
2019-01-29 09:00:26
i guess sometime later, then
Rotonen
2019-01-29 09:04:16
so `bazel build --java_toolchain=@bazel_tools//tools/jdk:toolchain_hostjdk8 :SurfMiner_deploy.jar` works
Rotonen
2019-01-29 09:04:49
so java 9 and java 10 are already deprecated, but they are per default broken on java < 9, but do not yet support java > 9? :smile:
Rotonen
2019-01-29 09:08:23
for whomever may concern
```
#!/usr/bin/env bash
bazel clean
for target in $(grep name BUILD | cut -d'"' -f2)
do
jar_name="$target"_deploy.jar
bazel build --java_toolchain=@bazel_tools//tools/jdk:toolchain_hostjdk8 ":$jar_name"
mv bazel-bin/"$jar_name" "$jar_name"
done
# EOF
```
Rotonen
2019-01-29 15:20:31
Some machines just seem to work with java8 and 11 installed.
Fireduck
2019-01-29 15:20:45
On some I need to set JAVA_HOME to java 8 for the build
Fireduck
2019-01-29 15:21:28
As far as I can tell, all builts are always java8
Fireduck
2019-01-29 19:25:15
yes, builds are per default java8, if available
Rotonen
2019-01-29 19:25:33
but the builds only work on java9 or newer
Rotonen
2019-01-29 19:26:02
i guess none of the devs do or test for ’unconfigured out of the box’
Rotonen
2019-01-29 19:26:18
or everyone is off java8 already
Rotonen